Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add parallelism to target defaults schema #27710

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Aug 30, 2024

Current Behavior

Parallelism is part of the project schema but not targetDefaults. This means it's highlighted as a warning in nx.json

Expected Behavior

There should be no warning.

@MaxKless MaxKless requested a review from a team as a code owner August 30, 2024 10:03
@MaxKless MaxKless requested a review from FrozenPandaz August 30, 2024 10:03
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 10:06am

@FrozenPandaz FrozenPandaz merged commit 4abcf61 into master Aug 30, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the add-parallelism-to-targetdefaults-schema branch August 30, 2024 14:28
FrozenPandaz pushed a commit that referenced this pull request Sep 3, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Parallelism is part of the project schema but not `targetDefaults`. This
means it's highlighted as a warning in `nx.json`

## Expected Behavior
There should be no warning.

(cherry picked from commit 4abcf61)
Copy link

github-actions bot commented Sep 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants